fix: finalize standalone MCP elicitation permission requests - #471
Merged
Merged
Conversation
A message-only MCP elicitation that is not tied to a Codex item is presented through `session/request_permission` with a synthetic tool call id. Nothing ever updated that tool call after the user answered, so clients kept an unfinished, untitled card (LLM-29763). Give the synthetic tool call a generic title and expose the question in `rawInput.description`, and send a `tool_call_update` with `status: completed` and the chosen action once the user responds. Correlated tool-call approvals are unchanged: the real tool call is completed by Codex itself.
AlexandrSuhinin
changed the title
Collaborator
Author
|
Related issue: https://youtrack.jetbrains.com/issue/LLM-29763 |
AlexandrSuhinin
requested review from
Rizzen and
nikita-ashihmin
and removed request for
nikita-ashihmin
September 4, 2026 10:25
Rizzen
approved these changes
Sep 7, 2026
AlexandrSuhinin
marked this pull request as ready for review
September 8, 2026 08:18
AlexandrSuhinin
deleted the
suhinin/mcp-elicitation-tool-call-finalize
branch
September 8, 2026 08:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.